Changed exec for spawn, added better params handling & parsing multiple files#2
Open
jmunox wants to merge 7 commits intoYvem:masterfrom
Open
Changed exec for spawn, added better params handling & parsing multiple files#2jmunox wants to merge 7 commits intoYvem:masterfrom
jmunox wants to merge 7 commits intoYvem:masterfrom
Conversation
…ild_process.exec', it calls, 'child_process.spawn' which avoids buffer limitations. It also allows to send specific arguments to the 'exiftool' shell command and to read EXIF info from multiple files at once.
Offirmo
reviewed
Nov 2, 2016
package.json
Outdated
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/Yvem/node-exif.git" | ||
| "url": "https://github.com/jmunox/node-exif.git" |
Author
There was a problem hiding this comment.
I can change that back and remove from npm. I just wanted to do a full test, including testing it as a module. What should i do?
There was a problem hiding this comment.
It's completely fine publishing you own version on npm (open source rulz !) However, you should not include the name/repo change in the PR to the initial repo
Author
There was a problem hiding this comment.
Changed it back to the original repo.
| (improved !) API. | ||
| Changed the implementation. | ||
|
|
||
| Mayor Changes: |
|
However, I can't be merged because:
|
|
The other features are nice. |
Author
|
hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Yves,
I made some changes on the code.
Instead of calling 'exiftool' through 'child_process.exec', it calls: child_process.spawn which avoids buffer limitations.
It also allows to send specific arguments to the 'exiftool' shell command
It can read EXIF info from multiple files at once by calling the path to a folder instead of a file
You can check on https://github.com/jmunox/node-exif
Cheers
Jesus